Wireshark AppleTalk dissector improvements.

[NJRoadfan]

Had some spare time last week and decided to contribute some improvements to Wireshark. A few of these were gripes because I use Wireshark ALOT when working on Netatalk.

-The AFP dissector now properly decodes the ProDOS information block. This one was annoying because Wireshark kept throwing exceptions due to treating this block as an offset for a UTF8 filename. Its been fixed and now when you packet monitor traffic from your Apple II, it properly decodes it.

-Support for MacIP packet dissection has been added. Decoding the packets is easy since they are IPv4 packets with a DDP header, so they get passed off to the IPv4 dissector. I did go a step further and add support for the ATP IP address configuration packets, which the draft IETF paper called "MacIP Gateway Protocol". Way fancier sounding than it really is. If anything it was planned for more and development stopped when it reached the "it works, ship what we have and worry about the rest later" stage. Well, later never came!

I hope to make further improvements if/when I have time. I know @robin-fo has some additions that were worked one (I've seen ADSP decoding and LToUDP support). Don't be afraid to submit a PR. The folks at Wireshark are pretty chill!

 

[wthww]

This is awesome, thanks for your contribution @NJRoadfan!

 

[thecloud]

I hope to make further improvements if/when I have time. I know @robin-fo has some additions that were worked one (I've seen ADSP decoding and LToUDP support). Don't be afraid to submit a PR. The folks at Wireshark are pretty chill!

AURP packet dissection support has also been done; there is a plugin at https://github.com/bytex64/aurp-dissector which worked well for us this past March. As long as Wireshark is accepting PRs then maybe he can contribute this one as well.

 

[slipperygrey]

we have two hurdles to overcome to get bytex64's AURP dissector into Wireshark proper:

it needs to be rewritten from Lua to C, as per the Wireshark Developer's Guide (unless we can make an argument that it absolutely has to be in Lua)

bytex64 needs to apply a GPL-2.0-or-later compatible license blurb to his code, if he or someone else is to use it as basis for an MR submission to Wireshark

while I appreciate the tongue-in-cheek tone of the current blurb, the GPL licenses forbid any kind of explicit obstacle to commercial use (and I doubt he wants a thousand emails everyday from everyone who uses Wireshark at work :-D )