I resubmitted the patch, fixing the issues the maintainer brought up. We'll see how it goes.
-
Updated 2023-07-12: Hello, Guest! Welcome back, and be sure to check out this follow-up post about our outage a week or so ago.
TashRouter: An AppleTalk Router
- Thread starter tashtari
- Start date
slipperygrey
Well-known member
Excellent job, thank you for filing this patch, and keeping the DDP dream alive!
Thanks! It appears that it was accepted into the net tree this morning. I'm not sure exactly what that means for which Linux release it'll be included with because 6.9 is so far into the release cycle at this point (6.9-rc7 was released a few days ago). Probably either 6.9 if we're lucky, or otherwise 6.10.
I think I didn't completely follow the correct process because I asked for the patch to go in the net tree (bug fixes) rather than net-next (new features), but I didn't add a "Fixes:" tag because the bug predates Git so I didn't have a SHA to use for the tag. I wasn't sure if you're supposed to use the first SHA in the kernel (Linus importing the whole project into Git) or what, so I just omitted it, even though I think they want you to always have a Fixes tag for commits added to the net tree. I was kind of worried that I would get some pushback on that, but it looks like they accepted it to "net" anyway.
I think I didn't completely follow the correct process because I asked for the patch to go in the net tree (bug fixes) rather than net-next (new features), but I didn't add a "Fixes:" tag because the bug predates Git so I didn't have a SHA to use for the tag. I wasn't sure if you're supposed to use the first SHA in the kernel (Linus importing the whole project into Git) or what, so I just omitted it, even though I think they want you to always have a Fixes tag for commits added to the net tree. I was kind of worried that I would get some pushback on that, but it looks like they accepted it to "net" anyway.
slipperygrey
Well-known member
That was surprisingly smooth! This will definitely benefit us in the short to mid term.
I pushed an update to the wiki page with this new status of the patch. https://netatalk.io/docs/AppleTalk-Kernel-Module
I pushed an update to the wiki page with this new status of the patch. https://netatalk.io/docs/AppleTalk-Kernel-Module
cheesestraws
Well-known member
twelvetone12
Well-known member
Bravo! Well done!
Thanks! It looks like the net tree for 6.9-rc8 (which might become the final 6.9) was sent to Linus today and it contains the patch. Linus already merged it and you can see that the mainline tree now contains the patch too.
So...I'm pretty sure we squeezed this in just in time before the final release of 6.9.
So...I'm pretty sure we squeezed this in just in time before the final release of 6.9.
slipperygrey
Well-known member
Wow, that is incredibly fortunate! What incredibly good timing for a patch a submission.
Current stable Debian Bookworm is on Linux 6.1 and the upcoming Trixie currently on 6.7 IINM. It’ll be interesting to observe if the Debian team will pull in the bleeding edge kernel before freezing the next stable, which is at least 6 months out I think.
Current stable Debian Bookworm is on Linux 6.1 and the upcoming Trixie currently on 6.7 IINM. It’ll be interesting to observe if the Debian team will pull in the bleeding edge kernel before freezing the next stable, which is at least 6 months out I think.
